-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vector3d.scatter()
reproject onto hemisphere functionality
#307
Add Vector3d.scatter()
reproject onto hemisphere functionality
#307
Conversation
Just ping me whenever this is ready for review. EDIT: I typically use the "Mark as draft" and "Mark as ready for review" functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice addition to the scatter()
convenience plotting method! I've made some requests. I think a mention of this possibility in the stereographic projection user guide should be added. Perhaps it is most suitable to add it to the end of the "Upper and/or lower hemisphere" part (here)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docstring improvements and addition to the user guide. I've got a few more requests before approving.
Description of the change
As discussed with @hakonanes in #306 (comment)
We should include the option to reproject vectors onto the visible hemisphere, ie. if
Vector3d.scatter(hemisphere='upper')
is called then vectors projected onto the lower hemisphere are not shown. This PR adds thereproject
argument toVector3d.scatter()
which reprojects vectors located on the hidden hemisphere to the visible hemisphere. This is achieved by reflection of the vectors in the x-y plane.The reprojected vectors are displayed with a
'+'
marker by default and can be set using thereproject_marker
argument. Ifhemisphere='both'
,reproject=True
has no effect as all vectors are already shown on one of the two axes.If approved the changes in this PR should be used to simplify #306.
Progress of the PR
Minimal example of the bug fix or new feature
reproject=True
has no effect ifhemisphere='both'
:For reviewers
__init__.py
.unreleased section in
CHANGELOG.rst
.