Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring pattern code can now be upstreamed to diffsims #689

Closed
pc494 opened this issue Dec 23, 2020 · 1 comment
Closed

Ring pattern code can now be upstreamed to diffsims #689

pc494 opened this issue Dec 23, 2020 · 1 comment
Labels
enhancement
Milestone
v0.13.0

Comments

@pc494
Copy link
Member

pc494 commented Dec 23, 2020

After the merging of pyxem/diffsims#117 we can now remove the equivalent (copy pasted) code from pyxem. I will do this after diffsims 0.4.0.rc1 is made so that the change is in and tested by the time we come to package 0.13.0 (cc #666)
@pc494 pc494 added this to the v0.13.0 milestone Dec 23, 2020
@pc494
Copy link
Member Author

pc494 commented Jan 5, 2021

This is #705

@pc494 pc494 closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.13.0
Development

No branches or pull requests
1 participant
@pc494