Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving away from RNG bases in testing #463

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

pc494
Copy link
Member

@pc494 pc494 commented Aug 27, 2019


name: Moving away from RNG bases in testing
about: We used to test that any random basis gives a change, now we use a specific one.


Release Notes

developer change
Summary: n/a

What does this PR do? Please describe and/or link to an open issue.
#458 is currently failing on a Random Number Generator test, in this case
a) the RNG doesn't actually aid us in testing the functionality
b) Debugging it isn't really possible

So I've removed the random element in the failing test.

@pc494 pc494 added this to the v0.10.0 milestone Aug 27, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f788975 on pc494:bugfix-rng-in-tests into fed6233 on pyxem:master.

@pc494
Copy link
Member Author

pc494 commented Aug 27, 2019

This does what it was meant to; but as noted in #461 the appveyor is upset about something unrelated to these PR's

@dnjohnstone
Copy link
Member

Good change, do you have any idea what the appveyor issue is about? I know it's not this, but I also don't know what it is...

@dnjohnstone dnjohnstone merged commit 356ca1c into pyxem:master Aug 27, 2019
@pc494 pc494 deleted the bugfix-rng-in-tests branch November 7, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants