Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hyperspy_release_next_minor into the master development branch #832

Merged
merged 56 commits into from
Apr 28, 2022

Conversation

magnunor
Copy link
Collaborator

@magnunor magnunor commented Apr 27, 2022

  • Remove the changes in workflows/build.yml

magnunor and others added 30 commits March 1, 2022 11:22
So we can fix any bugs related to changes in signal.map
… robustness. Changed tests to mirror this change
Fix radial_average issues due to HyperSpy map changes
…so removed checking 0th term in correlation for symmetry coefficient.
The internal structure of the class was slightly reworked, and some
bugs fixed.

In addition, the unit tests for the function was slightly restructured
to improve readability.

Note that the cross correlation functionality is currently not working
correctly.
…or_hyperspy_map

Fix subpixel refinement generator due to changes in HyperSpy map
…spy_map

Fix issue in integration_generator due to changes in HyperSpy map
Skipping failing tests using older Template matching
Remove setting axes unnecessarily and simplify code
CSSFrancis and others added 22 commits April 26, 2022 10:10
Remove setting axes unnecessarily and simplify code, part 2
Remove whitespace

Co-authored-by: Magnus Nord <magnunor@gmail.com>
Update changelog: .map changes, and lazy_result change to lazy_output
@magnunor
Copy link
Collaborator Author

Waiting to see if there are any additional tests failing, if not, I think this should be ready for merging

@magnunor magnunor mentioned this pull request Apr 27, 2022
@CSSFrancis
Copy link
Member

@magnunor I just scrolled through the changes and nothing really jumped out at me. I think I can merge #833 and then after running the CI we can merge with the master branch.

@magnunor
Copy link
Collaborator Author

@CSSFrancis, sounds good!

@magnunor magnunor merged commit 664ecf4 into master Apr 28, 2022
@magnunor magnunor deleted the hyperspy_release_next_minor branch May 7, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants