Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for XNAT Pipelines #139

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Basic support for XNAT Pipelines #139

merged 2 commits into from
Jul 26, 2021

Conversation

jhuguetn
Copy link
Contributor

This PR includes basic functionalities for running and monitoring XNAT pipelines.
Some CI tests for the added methods are also included to keep the coverage ratio.

@jhuguetn
Copy link
Contributor Author

PR branch rebased

@jhuguetn
Copy link
Contributor Author

jhuguetn commented Jul 8, 2021

PR branch rebased (again)

@jhuguetn
Copy link
Contributor Author

PR rebased and ready to merge @xgrg

@xgrg
Copy link
Contributor

xgrg commented Jul 21, 2021

Thank you @jhuguetn. We already have discussed most of it offline.
One last question though: can you briefly comment on why the add function was removed?

@jhuguetn
Copy link
Contributor Author

jhuguetn commented Jul 26, 2021

Few reasons,

  • Function is currently not working nor under Unit Testing control.
  • Functionality is not listed as a supported one in the XNAT API directory (see Project Pipeline Management API).
  • Generally speaking I don't like adding administrative features to pyxnat. At this stage I think we should prioritize user-related ones.
  • This PR focuses on adding support to basic Pipeline functionalities.
  • Note that add() code content is left commented for future work (if that would apply).

@xgrg
Copy link
Contributor

xgrg commented Jul 26, 2021

Got it, thanks. That was worth asking the question.

@xgrg xgrg merged commit 6d724f5 into pyxnat:master Jul 26, 2021
@jhuguetn jhuguetn deleted the pipelines branch August 12, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants