Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest ember-modifier and support location from conventional locations #5

Merged
merged 5 commits into from
May 28, 2021

Conversation

iambenchen
Copy link
Contributor

#4

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One (not-a-blocker) change I'd suggest here. Thank you for doing this!

addon/index.js Outdated Show resolved Hide resolved
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
@pzuraq
Copy link
Owner

pzuraq commented May 28, 2021

it looks like CI isn't running unfortunately, probably need to update this to GH actions. Will merge and run tests locally before I publish. Thanks for the help!

@pzuraq pzuraq merged commit 064c3ba into pzuraq:master May 28, 2021
@pzuraq pzuraq added the bug Something isn't working label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants