ci: drop support for node 4.x and node 6.x #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdiliberto
force-pushed
the
fix-ci
branch
2 times, most recently
from
b41d513
to
4283a0d
Compare
alexdiliberto
changed the title
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #61 (comment)
@pzuraq Having all kinds of issues on CI with the combination of Yarn + Node 4.x || 6.x. Going directly to Node 8.x min version support just works.
Initially attempted to
ember-cli-updatemy way to latest this morning but for this addon it's non-trivial, meaning I can't just do it in an hour.Are you willing to drop support for Node 4.x && 6.x on a new major semver release?
Next steps would be to
ember-cli-updateour way to latest.related yarn/babel issues:
yarnpkg/yarn#6914
babel/babel#8269