Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test coverage for c3/optimizers/c2.py #118

Closed
lazyoracle opened this issue Jul 1, 2021 · 0 comments · Fixed by #119
Closed

Missing test coverage for c3/optimizers/c2.py #118

lazyoracle opened this issue Jul 1, 2021 · 0 comments · Fixed by #119
Assignees
Labels
code-quality General code quality related issues and PRs
Milestone

Comments

@lazyoracle
Copy link
Member

Is your feature request related to a problem? Please describe.
We don't have good test coverage for c3/optimizers/c2.py. Currently it is at 33%

Describe the solution you'd like
Add tests to check the full C2 Calibration workflow

Additional context
A mock experiment must be provided to mimic the behaviour of hardware calibration. This could be something very rudimentary since we already have a more sophisticated workflow in the examples/Simulated_calibration.ipynb that is also checked as part of our CI.

@lazyoracle lazyoracle added the code-quality General code quality related issues and PRs label Jul 1, 2021
@lazyoracle lazyoracle added this to the 1.3 milestone Jul 1, 2021
@lazyoracle lazyoracle self-assigned this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality General code quality related issues and PRs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant