Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivity code is stale and broken #121

Closed
6 tasks done
lazyoracle opened this issue Jul 3, 2021 · 0 comments · Fixed by #125
Closed
6 tasks done

Sensitivity code is stale and broken #121

lazyoracle opened this issue Jul 3, 2021 · 0 comments · Fixed by #125
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@lazyoracle
Copy link
Member

lazyoracle commented Jul 3, 2021

Describe the bug

Code for Sensitivity Analysis in c3/optimizers/sensitivity.py is broken since it has not been updated with the rest of the codebase.

To Reproduce

python c3/main.py test/sensitivity.cfg will throw a bunch of errors due to stale config files and stale code.

Expected behavior

  • Sensitivity Analysis has significant overlap with Model Learning code, in that they use the same goal function. Ideally, the SET class should be derived from the Model Learning C3 class, re-implementing and extending as required
  • run Sensitivity Analysis from the CLI with a working config file
  • run Sensitivity Analysis in an interactive notebook
  • Tests to check that code works as expected (this would require some way to quantify that sensitivity analysis is working, because right now it seems the only way to do that is look at plots)
  • Module level docstrings
  • Tutorial style documentation (either as a part of or following the Model Learning docs)

Additional context

Implementing SET as derived from C3 might either involve making a new class derived from the base Optimizer which is then derived by both C3 and SET or leaving C3 as is and just deriving SET from it. This will depend on how different the two classes are.

Relevant sections in literature -

@lazyoracle lazyoracle added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 3, 2021
@lazyoracle lazyoracle added this to the 1.3 milestone Jul 3, 2021
@lazyoracle lazyoracle self-assigned this Jul 3, 2021
@lazyoracle lazyoracle mentioned this issue Jul 5, 2021
6 tasks
@lazyoracle lazyoracle mentioned this issue Jul 6, 2021
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant