Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No complete notebook showing Model Learning using c3-toolset #91

Closed
14 tasks done
lazyoracle opened this issue May 19, 2021 · 1 comment · Fixed by #117
Closed
14 tasks done

No complete notebook showing Model Learning using c3-toolset #91

lazyoracle opened this issue May 19, 2021 · 1 comment · Fixed by #117
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@lazyoracle
Copy link
Member

lazyoracle commented May 19, 2021

Is your issue related to a problem? Please describe.
There is no demonstration notebook showing how one would perform the whole cycle of c3-toolset including the model learning phase.

  • Bug Fix: Model Learning is broken
  • Feature Req: No Model Learning notebook

Describe the solution you'd like

  • Define a simple model (configs and hjsons) - Can we use one of the existing ones that are present for two_qubits.ipynb/Simulated_calibration.ipynb or in one of the tests?
  • Run C1 and C2 on this model (or just run C2 at least?)
  • Store the data being generated in the C2 step (How? Similar to c3-paper? Just store a pickle file? numpy arrays?)
  • Read the data stored in previous step and parse all the values (including reloading the current model from a config file)
  • Run C3 model learning with this data on the previously defined model

If beyond the scope, it might be adequate to start directly from step 4 with some dummy dataset from a previous C2 run and perform model learning on that data.

TO-DO/Status

  • Trace current function paths
  • Check points where API is broken due to updates elsewhere
  • Explore and understand code/API design choices (data structure, FOMs, sampling, data assumptions)
  • Change/Update code/implementation structure as required
  • Change/Update API design as required
  • Update data structure and storage format to something portable and sensible ( might relate to data saving in C2, save as dataframes instead of list of dicts)
  • Check/update integration with main.py and Optimizer
  • Check/update integration with config files
  • Run Model Learning from CLI
  • Update Docstrings and Type Annotations
  • Update config files
  • Add tests
  • Create Model Learning Notebook as outlined above
  • Add docs based on examples

Note
Model Learning Experimentation being tracked in a separate issue #105

@lazyoracle lazyoracle added the enhancement New feature or request label May 19, 2021
@lazyoracle lazyoracle added this to the 1.3 milestone May 19, 2021
@lazyoracle lazyoracle self-assigned this May 19, 2021
@lazyoracle lazyoracle added the bug Something isn't working label May 30, 2021
@lazyoracle lazyoracle mentioned this issue May 31, 2021
17 tasks
@lazyoracle
Copy link
Member Author

Call graph for current code:
c3uses dot

@lazyoracle lazyoracle removed this from the 1.3 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant