Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Should we use or not testcontainer ryuk ? #7

Open
cmoulliard opened this issue Nov 9, 2023 · 3 comments
Open

Question: Should we use or not testcontainer ryuk ? #7

cmoulliard opened this issue Nov 9, 2023 · 3 comments
Labels
question Further information is requested

Comments

@cmoulliard
Copy link
Collaborator

Question

Should we use or not testcontainer ryuk ? I'm asking such a question as for non tekton scenarios where users will use podman (inside the VM) to garbage collected the containers launched during the tests BUT not killed

If the answer to the question is yes; then the following ticket could help us to let ryuk to work with podman:
testcontainers/moby-ryuk#23 (comment)

@iocanel
Copy link
Collaborator

iocanel commented Nov 9, 2023

I think that we should use TESTCONTAINERS_RYUK_DISABLED.

Do you think that quarkus dev services are affected by this issue? Have you encountered a problem that indicates there is a problem?

@cmoulliard
Copy link
Collaborator Author

I did a test where TESTCONTAINERS_RYUK_DISABLED=false and that works too. So we will keep ryuk as it allows to remove the containers created

Example:

[maven : mvn-goals] 2023-11-10 08:15:53,156 INFO  [🐳 .io/postgres:14]] (build-52) Container docker.io/postgres:14 is starting: 63f24312c812c5671a8be768bbcdb1005a35279485f5340b515ee74cf4fd7961
[maven : mvn-goals] 2023-11-10 08:15:59,980 INFO  [🐳 .io/postgres:14]] (build-52) Container docker.io/postgres:14 started in PT7.149217S
[maven : mvn-goals] 2023-11-10 08:15:59,980 INFO  [io.qua.dev.pos.dep.PostgresqlDevServicesProcessor] (build-52) Dev Services for PostgreSQL started.
[maven : mvn-goals] 2023-11-10 08:15:59,983 INFO  [io.qua.dat.dep.dev.DevServicesDatasourceProcessor] (build-52) Dev Services for the default datasource (postgresql) started - container ID is 63f24312c812

Podman ps

[fedora@fedora38 ~]$ podman ps; podman ps -a
CONTAINER ID  IMAGE       COMMAND     CREATED     STATUS      PORTS       NAMES
CONTAINER ID  IMAGE       COMMAND     CREATED     STATUS      PORTS       NAMES

@iocanel

cmoulliard added a commit that referenced this issue Nov 10, 2023
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
@cmoulliard
Copy link
Collaborator Author

Can we close it based on my last comment ? @iocanel

@cmoulliard cmoulliard added the question Further information is requested label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants