Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 15 #18

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Issue 15 #18

merged 3 commits into from
Nov 27, 2023

Conversation

cmoulliard
Copy link
Collaborator

Copy link
Collaborator

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a comment about some options that can be removed.
Feel free to remove and merge.

pipelines/pipelines/quarkus-maven-build.yaml Outdated Show resolved Hide resolved
@cmoulliard
Copy link
Collaborator Author

cmoulliard commented Nov 23, 2023

I propose then that we also rename the maven-build task to maven-test and that we handle build/deployment part of the latest new task maven-deploy that I will rename to maven-build-image-deploy

@cmoulliard
Copy link
Collaborator Author

No Quarkus pod is created using the following parameters. Idea to fix that ? @iocanel
Screenshot 2023-11-23 at 14 05 40

Copy link
Collaborator

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel
Copy link
Collaborator

iocanel commented Nov 24, 2023

No Quarkus pod is created using the following parameters. Idea to fix that ? @iocanel Screenshot 2023-11-23 at 14 05 40

No, I will have to try it out myself

@iocanel
Copy link
Collaborator

iocanel commented Nov 24, 2023

I'll hold the PR open, till we figure out why the pod is not really created.

…on ocp. #15

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants