Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between Normal, Default and Overridden workflows in workflow_overview_all() #4

Open
inadarei opened this issue Oct 25, 2010 · 1 comment

Comments

@inadarei
Copy link

When workflows are exportable they can be in one of the following three states:

  • Normal - database-only
  • Default - code-only
  • Overridden - provided by code, but overridden in the database.

There are cases when operation titles have to be different depending on the state. One such very common case is for "edit" operation. In all existing exportable UIs, the edit link says "edit" if an object is Normal or Overridden, but says "Override" if the object is Default, allowing very important ability for users to identify objects that have not, yet, been overridden.

I am going to fix this in my fork by allowing links array to supply "title_default" which will be used instead of the "title" key, if object is in Default state.

Obviously, there could be a more generic case, allowing modules to also supply "title_normal" and "title_overridden". However, the only known and widespread case that we know of, right now, is the case of "Edit/Override", so I am avoiding preemptive complication of code, unless we see that it is necessary. Trying to keep it simple, for now.

@q0rban
Copy link
Owner

q0rban commented Oct 25, 2010

Makes sense to me. I will have a look at your code to check out your implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants