[Improvement - LOW] Some minor corrections to the new Snow theme

[pupi1985]

If they are not clear then let me know and I can provide a before and after screenshot.

By the way, I'm not so sure it is a good idea to name the new Snow theme the same way as the old one. I'm thinking about someone making a plugin that checks for the Snow theme and then matching a different one.

I also think applying borders to every td is too much:

table tbody tr td {
    padding: 10px 0;
    border-top: 1px solid #ecf0f1;
    border-bottom: 1px solid #ecf0f1;
    display: table-cell;
}

Particularly after seeing how wide forms with labels are being displayed (horizontal lines both up and down on labels). Looks like it is too dense in horizontal lines. This includes plugins, profile section, admin permissions, etc. Not to mention the label for a tall checkbox does not have that because it is applies border: none in td.qa-form-tall-label so it is not always with the lines either so checkboxes for tall or wide make the impression that they are separators.

I'm attaching some screenshots of these 2 commits:

• Allowed new sections to be added to the right side of the profile section
• Removed the unnecessary white space in the profile section

Current state for a user profile that results in a lot of white space after the type field:

After removing the minimal height we can see the profile section is holding the components on the right, which will be annoying when trying to add new sections to the theme:

After the fix:

Note the minimal height can be kept and the new sections will still be aligned because of the clear. However, I think the reason why the minimal height was there was to hold the components on the right.

[svivian]

Thanks for this. Unfortunately the CSS is currently being generated via SASS (which Jatin did not wish to publish, and I didn't really want in the repo anyway). But not to worry, I'm currently applying some of these manually in the SASS code.

I have changed the theme name to SnowFlat for now since there is still some work to do and I want to get the beta out the door.

I agree about the table borders, I've removed the generic selector and put them on the wide table only.

There are some other problems with the SASS code at the moment (such as too much unnecessary nesting, causing bloated selectors) so I will try and clean it up asap to the point where we can directly edit the CSS going forward.

[svivian]

OK now fixed all this in new commits. Thanks again.

[pupi1985]

Great. I'll update my repo, take a look at this and report back if I notice any issue. Thanks.