Some commits with minor improvements

[pupi1985]

I have a branch with a few minor improvements that I thought it would make sense to share.

The only one that may make sense to explain is 2b4c4d5. The idea is basically to avoid calling qa_load_modules_with, which calls qa_list_modules($type) which ends up calling array_keys too many times. I'd say it should be faster but I haven't benchmarked it. Anyway, it is more readable to have qa_load_all_modules_with function rather than having to iterate over them all.

Additionally, I thought that removing the global variable $qa_modules from functions that only read it would provide more encapsulation. I would even add items to it by a function encapsulating as much as possible, but as I mentioned before, I'm just throwing some ideas.

[svivian]

Thanks for the updates. A few notes:

• I renamed the encapsulation function to qa_list_modules_info to keep the naming inline with the other functions (they all retrieve registered modules so the function name doesn't need to contain registered).

• I reverted the body_script placement. Script order is important so we don't want it to fail for anyone who has overridden that function. It's only 2 lines of JS so there is no drawback to being at the top.

• Just a heads-up for future development: I'm using braces for any control statements that span multiple lines even if not necessary. In other words:

  // old/current style
  foreach ($arr as $var)
      if (something)
          do_something();
  
  // new preferred style
  foreach ($arr as $var) {
      if (something)
          do_something();
  }
  

I'll add more coding style details to the contributing.md document soon.

[pupi1985]

Great, thanks. I'll keep the formatting in mind next time :)