Rm lang key "caching_dir_public" #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This key isn't used since f394a34 . Removing it ensures translators don't bother translating it for nothing
gturri
added a commit
to gturri/q2a-lang-fr
that referenced
this pull request
Dec 30, 2018
* add translations missing in Q2A 1.8.0 * reorder some translations to match the order of they of the en files (it makes it easier to spot missing translations) Note that the string for caching_dir_public hasn't been translated because the usage of this key has actually been removed from Q2A (see q2a/question2answer#721 for more context)
|
Thanks! I did consider using that for a "warning" message instead of error but the current system doesn't allow for that, only errors. Plus seeing a warning all the time might get annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This key isn't used since f394a34 . Removing
it ensures translators don't bother translating it for nothing