Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/signature: implement personal_recover (eip 191) #21

Merged
merged 5 commits into from Dec 14, 2021
Merged

Conversation

q9f
Copy link
Owner

@q9f q9f commented Dec 14, 2021

ref #15

Eth::Signature.personal_recover message, signature, chain_id

  • moved from Eth::Key to Eth::Signature namespace because recovering Signatures work without known keys
  • added support for chain IDs (EIP 155)

works entirely with rbsecp256k1 (no openssl)

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #21 (5716bbb) into main (80c27fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        13    +2     
  Lines          390       433   +43     
=========================================
+ Hits           390       433   +43     
Impacted Files Coverage Δ
lib/eth.rb 100.00% <100.00%> (ø)
lib/eth/address.rb 100.00% <100.00%> (ø)
lib/eth/chains.rb 100.00% <100.00%> (ø)
lib/eth/signature.rb 100.00% <100.00%> (ø)
spec/eth/chains_spec.rb 100.00% <100.00%> (ø)
spec/eth/signature_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c27fe...5716bbb. Read the comment docs.

@q9f q9f added the breaking change Should clearly be documented label Dec 14, 2021
@q9f q9f merged commit 5303b25 into main Dec 14, 2021
@q9f q9f deleted the q9f/key/sing branch December 14, 2021 14:38
@q9f q9f mentioned this pull request Dec 15, 2021
5 tasks
@q9f q9f added the enhancement New feature or request label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Should clearly be documented enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants