Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: improve error handling #39

Merged
merged 7 commits into from
Jan 9, 2022
Merged

lib: improve error handling #39

merged 7 commits into from
Jan 9, 2022

Conversation

q9f
Copy link
Owner

@q9f q9f commented Jan 9, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #39 (5bcc903) into main (3084cfa) will increase coverage by 0.47%.
The diff coverage is 98.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   99.32%   99.80%   +0.47%     
==========================================
  Files          35       35              
  Lines        2520     2561      +41     
==========================================
+ Hits         2503     2556      +53     
+ Misses         17        5      -12     
Impacted Files Coverage Δ
lib/eth/tx/eip1559.rb 98.67% <85.71%> (+1.98%) ⬆️
lib/eth/tx/eip2930.rb 98.61% <85.71%> (+2.08%) ⬆️
lib/eth/tx.rb 98.94% <93.75%> (+1.12%) ⬆️
lib/eth/abi.rb 100.00% <100.00%> (ø)
lib/eth/address.rb 100.00% <100.00%> (ø)
lib/eth/chain.rb 100.00% <100.00%> (ø)
lib/eth/eip712.rb 100.00% <100.00%> (ø)
lib/eth/key.rb 100.00% <100.00%> (ø)
lib/eth/key/decrypter.rb 100.00% <100.00%> (ø)
lib/eth/key/encrypter.rb 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3084cfa...5bcc903. Read the comment docs.

@q9f q9f merged commit e4b1b4a into main Jan 9, 2022
@q9f q9f deleted the q9f/lib/clean branch January 9, 2022 16:01
@q9f q9f added the refactor Improving the architecture label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improving the architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants