fix(interface): use virtual destructors for all interfaces

Avoids memory leak if derived classes are deleted through interface pointer.

Fix #6006

src/audio/iaudiocontrol.h

@@ -105,6 +105,7 @@ class IAudioControl : public QObject
     Q_OBJECT
 
 public:
+    virtual ~IAudioControl() = default;
     virtual qreal outputVolume() const = 0;
     virtual void setOutputVolume(qreal volume) = 0;
     virtual qreal maxOutputVolume() const = 0;

src/audio/iaudiosettings.h

@@ -26,6 +26,8 @@
 
 class IAudioSettings {
 public:
+    virtual ~IAudioSettings() = default;
+
     virtual QString getInDev() const = 0;
     virtual void setInDev(const QString& deviceSpecifier) = 0;
 

src/audio/iaudiosink.h

@@ -97,7 +97,7 @@ class IAudioSink
         return {};
     }
 
-    virtual ~IAudioSink() {}
+    virtual ~IAudioSink() = default;
     virtual void playAudioBuffer(const int16_t* data, int samples, unsigned channels,
                                  int sampleRate) const = 0;
     virtual void playMono16Sound(const Sound& sound) = 0;

src/audio/iaudiosource.h

@@ -34,7 +34,7 @@ class IAudioSource : public QObject
 {
     Q_OBJECT
 public:
-    virtual ~IAudioSource() {}
+    virtual ~IAudioSource() = default;
 
     virtual operator bool() const = 0;
 

src/core/icoresettings.h

@@ -35,6 +35,7 @@ class ICoreSettings {
         ptSOCKS5 = 1,
         ptHTTP = 2
     };
+    virtual ~ICoreSettings() = default;
 
     virtual bool getEnableIPv6() const = 0;
     virtual void setEnableIPv6(bool enable) = 0;

src/model/about/iaboutfriend.h

@@ -28,6 +28,7 @@
 class IAboutFriend
 {
 public:
+    virtual ~IAboutFriend() = default;
     virtual QString getName() const = 0;
     virtual QString getStatusMessage() const = 0;
     virtual ToxPk getPublicKey() const = 0;

src/model/dialogs/idialogs.h

@@ -27,6 +27,7 @@ class ToxPk;
 class IDialogs
 {
 public:
+    virtual ~IDialogs() = default;
     virtual bool hasContact(const ContactId& contactId) const = 0;
     virtual bool isContactActive(const ContactId& contactId) const = 0;
 

src/model/dialogs/idialogsmanager.h

@@ -28,6 +28,7 @@ class ToxPk;
 class IDialogsManager
 {
 public:
+    virtual ~IDialogsManager() = default;
     virtual IDialogs* getFriendDialogs(const ToxPk& friendPk) const = 0;
     virtual IDialogs* getGroupDialogs(const GroupId& groupId) const = 0;
 };

src/model/profile/iprofileinfo.h

@@ -37,6 +37,7 @@ class IProfileInfo
     enum class SetAvatarResult {
         OK, EmptyPath, CanNotOpen, CanNotRead, TooLarge
     };
+    virtual ~IProfileInfo() = default;
 
     virtual bool setPassword(const QString& password) = 0;
     virtual bool deletePassword() = 0;

src/persistence/ifriendsettings.h

@@ -39,6 +39,8 @@ class IFriendSettings
     };
     Q_DECLARE_FLAGS(AutoAcceptCallFlags, AutoAcceptCall)
 
+    virtual ~IFriendSettings() = default;
+
     virtual QString getContactNote(const ToxPk& pk) const = 0;
     virtual void setContactNote(const ToxPk& pk, const QString& note) = 0;
 

src/video/ivideosettings.h

@@ -27,6 +27,8 @@
 
 class IVideoSettings {
 public:
+    virtual ~IVideoSettings() = default;
+
     virtual QString getVideoDev() const = 0;
     virtual void setVideoDev(const QString& deviceSpecifier) = 0;