Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Dark theme? #1639

Closed
tr37ion opened this issue May 13, 2015 · 27 comments
Closed

Dark theme? #1639

tr37ion opened this issue May 13, 2015 · 27 comments
Labels
C-question The issue is a question M-ui Affected Module: User Interface P-low

Comments

@tr37ion
Copy link

tr37ion commented May 13, 2015

How can I change the default theme of qtox to something like this?

qTox dark theme mockup

@agilob
Copy link
Contributor

agilob commented May 13, 2015

You can't. That's not even a screenshot.

@tr37ion
Copy link
Author

tr37ion commented May 13, 2015

You can't. That's not even a screenshot.

So, I can't change it to a dark theme because I took it from https://tox.im/ as a base for my mockup?

Is it planned to make qtox themable then?
Which source file holds the current color settings?

@agilob
Copy link
Contributor

agilob commented May 13, 2015

Is it planned to make qtox themable then?
Which source file holds the current color settings?

#1640
Here this PR provides support for more themes, but it's not ready yet.

Before Support for user-created skins #1641, my PR must be fully tested and cleaned-up. It will take some time.

That picture you posted it a mockup made in Photoshop or GIMP. it's not a screenshot of existing implementation.

@tr37ion
Copy link
Author

tr37ion commented May 13, 2015

#1640
Here this PR provides support for more themes, but it's not ready yet.

Wow, this looks promising :) Is this qt-theming like qtconfig-qt4 offers?

Before Support for user-created skins #1641, my PR must be fully tested and cleaned-up. It will take some time.

Sure, take your time. I was just thinking that I may did something wrong or missed something to let qtox look like my other qt applications.

That picture you posted it a mockup made in Photoshop or GIMP. it's not a screenshot of existing implementation.

Yes, it was just a quick&dirty mockup by taking the one from https://tox.im/ and switch it to dark. I thought, this would be good enough to show what I was looking for. If you need a real one, I can do it if you want.

@agilob
Copy link
Contributor

agilob commented May 13, 2015

If you need a real one, I can do it if you want.

I'm bad at CSS so if you know how to improve dark themes in my PR, just do it.

@tux3 tux3 added the C-question The issue is a question label May 13, 2015
@tr37ion
Copy link
Author

tr37ion commented May 14, 2015

I cloned your repo and try to run your fork with qtcreator, but I get this:
Compile error

@agilob
Copy link
Contributor

agilob commented May 14, 2015

You tried compiling wrong branch, change branch to "more_themes" git checkout more_themes, than make clean && make -j4

@zetok zetok added P-low M-ui Affected Module: User Interface help wanted labels Aug 28, 2015
@zetok
Copy link
Contributor

zetok commented Oct 27, 2015

Thanks to @fcore117 from #2478:

Please add simple dark mode to chat window, something like this i dirty improvised with paint filling color.
capture

@fcore117
Copy link

Lets hope creating simple color themes without adding any cost to memory usage or cpu will come.

@UralZima
Copy link

+1. black bg on contact list and black on message window.

@UralZima
Copy link

UralZima commented Jul 7, 2017

Anything on this? I am still on Toxic because no dark mode in qTox exists

@Diadlo
Copy link
Member

Diadlo commented Jul 7, 2017

@UralZima No. Feel free to create it
Currently it's low-priority qTox issue

@dataphreak1001
Copy link

You would think after 2 years, they'd have made the themes editable by css.

@sudden6
Copy link
Member

sudden6 commented Feb 26, 2018

@dataphreak1001 the themes are editable by CSS, you just have to recompile qTox afterwards.

@tox-user
Copy link
Contributor

I guess the proper solution would be to allow making theme packs that can be changed without compiling.

@sudden6
Copy link
Member

sudden6 commented Feb 27, 2018

One solution could be, if we created a folder e.g. ~/config/qTox/css/ where you can put your own css that overwrites the existing one. Still not a high priority for me to work on.

@Diadlo
Copy link
Member

Diadlo commented Feb 27, 2018

AFAIK Qt allow to use custom style to any application with --style parameter without recompile

@tr37ion
Copy link
Author

tr37ion commented Feb 27, 2018

Is it really that difficult to just switch the background color of one existing theme to #222222 and Text color to #DDDDDD eg.? I opened the issue 2015 and I wonder what might be the issue that changing two color values is that complicated. I possibly miss something ...

@Chiitoo
Copy link
Contributor

Chiitoo commented Feb 27, 2018

tr37ion,

Looking at the previous issues, and/or pull requests concerning this, I think no one just wanted to slap something quick together, but actually create a proper theme implementation.

You can always try doing it yourself if you'd like to see what it takes. :]

I did, though I've only changed the colours of the buttons and things like that, and they're still very much hard-coded.

In the end, I feel the only reason for there being no dark theme still, as an option by default, is that no people with the desire to make it happen (without higher priorities taking their time already) have come around after the previous attempts (which unfortunately didn't get enough attention and get merged).

@sudden6
Copy link
Member

sudden6 commented Feb 27, 2018

@tr37ion it's not the problem to add another theme and change the color values, but to make sure the color and is applied in the correct places.

The styling in qTox seems pretty fragmented, with some parts using https://github.com/qTox/qTox/blob/master/src/widget/style.cpp and some applying CSS directly.

EDIT: The styling seems to be in a forgotten corner of the qTox code, I think all the devs that developed it aren't active anymore.

@tr37ion
Copy link
Author

tr37ion commented Feb 27, 2018

@sudden6 and @Chiitoo yes, there must be something else stopping a dev implementing this. Maybe it was my fault pasting a mock-up in the first place, which might gave the impression a complete new theme was desired.

Actually, I just thought one theme with an inverted chat room colourization might just do it. Therefore, I thought if devs know where to change those two colours (background-color and font color) it would be an easy 2minute task. I didn't expect it to be that difficult as it seems to be now.

@tox-user tox-user self-assigned this Mar 15, 2018
@tox-user tox-user removed their assignment Aug 28, 2018
@pizdjuk
Copy link

pizdjuk commented Dec 15, 2018

Please, do something with dark theme. Because using if qtox in a MATEBlack is impossible, while the fontcolor of chatwindow (where I write) is quite invisible and I dont know where to change it

@sudden6
Copy link
Member

sudden6 commented Dec 15, 2018

On master there's now an unofficial way to change the theme:

  1. Get the files from https://github.com/qTox/qTox/tree/master/themes/default they are the default theme
  2. Copy them to ~/.local/share/qTox/themes/default/
  3. Edit as you wish, restart qTox to apply

We are looking for someone to write a dark theme before creating the user interface for this.

@dhsdshdhk
Copy link

@sudden6, I can't seem to change the white background in the chat text area, as shown here. Is that defined by the css files or by style.cpp?

@sudden6
Copy link
Member

sudden6 commented Dec 31, 2018

@dhsdshdhk It seems that some colors are selected by a function in style.cpp. IMO this should be converted to a CSS file too. Would make theming a lot easier.

@dhsdshdhk
Copy link

In case anyone else wants it, I applied these changes to master and got the dark text background I was looking for. The theme is not well adjusted yet, but I'll edit it to make a good match.

@sudden6
Copy link
Member

sudden6 commented Feb 26, 2019

Dark theme is done by #5558

@sudden6 sudden6 closed this as completed Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-question The issue is a question M-ui Affected Module: User Interface P-low
Projects
None yet
Development

No branches or pull requests