Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

windows/bootstrap.sh requires tools/unzip that is missing #3153

Closed
Talkless opened this issue Apr 17, 2016 · 6 comments
Closed

windows/bootstrap.sh requires tools/unzip that is missing #3153

Talkless opened this issue Apr 17, 2016 · 6 comments
Labels
M-docs Affected Module: Documentation M-packaging Affected Module: Packaging OS-windows

Comments

@Talkless
Copy link
Contributor

Brief Description

OS: Windows 10
qTox version: HEAD
Qt: 5.6
Hardware: VirtualBox

Reproducible: Always

Steps to reproduce

Launch bootstrap.bat on Windows

Observed Behavior

cmd.exe printed that ../tools/unzip (something like that) command not found during compilation.

Additional Info

Here's reference to unzip in windows/bootstrap.sh (https://github.com/tux3/qTox/blob/master/windows/bootstrap.sh#L28):

if [ ! -d "include/tox" ]; then
    $QTOX_DIR/tools/unzip -o libtoxcore_build_windows_x86_shared_release.zip -d ./
fi

Build is still running as I am writing (using one core instead of eight... :-/ ) so not sure how it affects build.

I am not sure what was original idea was - having binary inside repository? Maybe INSTALL.md should have instruction to install http://gnuwin32.sourceforge.net/packages/unzip.htm ?

@sudden6
Copy link
Member

sudden6 commented Apr 17, 2016

@zetok seems to be an issue with #3104

@sudden6 sudden6 added M-packaging Affected Module: Packaging OS-windows labels Apr 17, 2016
@zetok
Copy link
Contributor

zetok commented Apr 17, 2016

Yeah.

I think that the right "solution" would be to wget from somewhere unzip.exe in the script..?

Or is there a better way to do it?

(doesn't windows, like, already supports zip format? can't that be used?)

@sudden6
Copy link
Member

sudden6 commented Apr 17, 2016

we could directly download it from http://www.info-zip.org/UnZip.html#Downloads but I don't see why this should be better than it was before.

@zetok
Copy link
Contributor

zetok commented Apr 17, 2016

@sudden6
Copy link
Member

sudden6 commented Apr 17, 2016

It would still be easier to read unzip.exe

@Talkless
Copy link
Contributor Author

If there is already need to download wGet and what not manually, I see no problem to also ask to download and install http://gnuwin32.sourceforge.net/packages/unzip.htm or that info-zip or whatever.

@zetok zetok added the M-docs Affected Module: Documentation label Apr 21, 2016
zetok added a commit to zetok/qTox that referenced this issue Apr 24, 2016
Also correct $PATH in windows instructions to work on x86_64.

Fixes qTox#3153
@zetok zetok closed this as completed in fa5ee5b Apr 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M-docs Affected Module: Documentation M-packaging Affected Module: Packaging OS-windows
Projects
None yet
Development

No branches or pull requests

3 participants