This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
windows/bootstrap.sh requires tools/unzip that is missing #3153
Labels
Comments
Yeah. I think that the right "solution" would be to wget from somewhere Or is there a better way to do it? (doesn't windows, like, already supports |
we could directly download it from http://www.info-zip.org/UnZip.html#Downloads but I don't see why this should be better than it was before. |
It would still be easier to read unzip.exe |
If there is already need to download wGet and what not manually, I see no problem to also ask to download and install http://gnuwin32.sourceforge.net/packages/unzip.htm or that info-zip or whatever. |
zetok
added a commit
to zetok/qTox
that referenced
this issue
Apr 21, 2016
zetok
added a commit
to zetok/qTox
that referenced
this issue
Apr 24, 2016
Also correct $PATH in windows instructions to work on x86_64. Fixes qTox#3153
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Brief Description
OS: Windows 10
qTox version: HEAD
Qt: 5.6
Hardware: VirtualBox
Reproducible: Always
Steps to reproduce
Launch bootstrap.bat on Windows
Observed Behavior
cmd.exe printed that
../tools/unzip
(something like that) command not found during compilation.Additional Info
Here's reference to unzip in windows/bootstrap.sh (https://github.com/tux3/qTox/blob/master/windows/bootstrap.sh#L28):
Build is still running as I am writing (using one core instead of eight... :-/ ) so not sure how it affects build.
I am not sure what was original idea was - having binary inside repository? Maybe INSTALL.md should have instruction to install http://gnuwin32.sourceforge.net/packages/unzip.htm ?
The text was updated successfully, but these errors were encountered: