Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

qTox does not build on Debian 8 Jessie because of QVector<T>::removeOne() usage #3416

Closed
Talkless opened this issue Jun 19, 2016 · 3 comments

Comments

@Talkless
Copy link
Contributor

Brief Description

OS: Debian 8 KDE
qTox version: HEAD
toxcore: HEAD
Qt: 5.3.2, stock Debian 8
Hardware: VirtualBox

Reproducible: Always

Steps to reproduce

Build qTox using stock Qt on Debian 8

Observed Behavior
src/widget/passwordedit.cpp: In member function ‘void PasswordEdit::unregisterHandler()’:
src/widget/passwordedit.cpp:47:31: error: ‘class QVector<QAction*>’ has no member named ‘removeOne’
         eventHandler->actions.removeOne(action);
                               ^

As removeOne() was added in Qt 5.4

Expected Behavior

Should build on all supported systems, mentioned on INSTALL.md.

I believe it should be stressed in contribution guidelines to use lowest-common-denominator Qt version. This is not the first time I have reported such incompatibility error.

@Talkless Talkless changed the title qTox does not build on Debian because of QVector<T>::removeOne usage() qTox does not build on Debian because of QVector<T>::removeOne() usage Jun 19, 2016
@Talkless Talkless changed the title qTox does not build on Debian because of QVector<T>::removeOne() usage qTox does not build on Debian 8 Jessie because of QVector<T>::removeOne() usage Jun 19, 2016
@Talkless
Copy link
Contributor Author

There are two usages of removeOne():
https://github.com/tux3/qTox/search?utf8=%E2%9C%93&q=removeOne

@Talkless
Copy link
Contributor Author

I'm working on a fix.

@Talkless
Copy link
Contributor Author

Second removeOne() was actually with QList<> which is OK. Only one file had to be changed.

Talkless added a commit to Talkless/qTox that referenced this issue Jun 19, 2016
QVector<T>::removeOne() was added in Qt 5.4, and this method usage
broke build for Debian 8 whitch has Qt 5.3.2.

Add alternative implementation and comment for the future to use
removeOne() when this becomes possible.

Closes qTox#3416
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant