Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

[regression] available video modes are too limited & even invalid #3588

Closed
zetok opened this issue Aug 4, 2016 · 0 comments
Closed

[regression] available video modes are too limited & even invalid #3588

zetok opened this issue Aug 4, 2016 · 0 comments
Labels
C-bug The issue contains a bug report M-video Affected Module: Video P-high
Milestone
v1.5.0

Comments

@zetok
Copy link
Contributor

zetok commented Aug 4, 2016

Brief Description

Setting available for choosing desired webcam resolution not only doesn't give all possible modes, but also gives modes that seem to be invalid.

OS: Linux
qTox version: v1.4.0-386-g0da1a2f
Commit hash: 0da1a2f
toxcore: 0.0.0
Qt: 5.6.1
Hardware:
…

Reproducible: Always

Steps to reproduce
  1. Go to settings
  2. Try to set 1280x720 mode
Observed Behavior

There's only 600p available -.-"

Expected Behavior

720p should be available

Additional Info

dat 600p

meanwhile, actually available modes, as listed in qTox's stdout, note that there's no 600p or 360p:

[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:339 : Debug: available Modes:
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 30.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 25.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 20.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 15.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 10.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 5.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 30.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 25.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 20.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 15.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 10.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 5.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 30.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 25.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 20.000000, pixel format: yuyv422
[16:01:22.011 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 15.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 10.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 5.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 30.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 25.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 20.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 15.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 10.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 5.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 15.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 10.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 5.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 10.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 5.000000, pixel format: yuyv422
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 30.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 25.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 20.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 15.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 10.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 360, FPS: 5.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 30.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 25.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 20.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 15.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 10.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 640, height: 480, FPS: 5.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 30.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 25.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 20.000000, pixel format: mjpeg
[16:01:22.012 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 15.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 10.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 320, height: 240, FPS: 5.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 30.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 25.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 20.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 15.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 10.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 160, height: 120, FPS: 5.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 30.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 25.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 20.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 15.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 10.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 960, height: 544, FPS: 5.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 30.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 25.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 20.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 15.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 10.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:201 : Debug: width: 1280, height: 720, FPS: 5.000000, pixel format: mjpeg
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:353 : Debug: selected Modes:
[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:271 : Debug: width: 960, height: 544, FPS: 30.000000, pixel format: mjpeg

[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:271 : Debug: width: 640, height: 360, FPS: 30.000000, pixel format: mjpeg

[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:271 : Debug: width: 320, height: 240, FPS: 30.000000, pixel format: mjpeg

[16:01:22.013 UTC] src/widget/form/settings/avform.cpp:271 : Debug: width: 160, height: 120, FPS: 30.000000, pixel format: mjpeg

Note: fix should be based on #3185 to not cause conflicts. Unless it won't cause conflicts with it, then no need to base it on the PR :)
@zetok zetok added C-bug The issue contains a bug report help wanted P-high M-video Affected Module: Video labels Aug 4, 2016
@zetok zetok added this to the v1.5.0 milestone Aug 4, 2016
initramfs added a commit to initramfs/qTox that referenced this issue Aug 4, 2016
@initramfs
fix(avform): add missing "first" video mode back to video modes
07ab151 
This commit fixes the fact that the selectBestModes() function strips
off the first video mode, often a 1080p or 720p mode.

This commit fixes issue qTox#3588.
@initramfs initramfs mentioned this issue Aug 4, 2016
Merged
@zetok zetok closed this as completed in 5324e76 Aug 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-bug The issue contains a bug report M-video Affected Module: Video P-high
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
1 participant
@zetok