Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Self name change notification from PK can be seen in groups #5686

Closed
anthonybilinski opened this issue May 24, 2019 · 0 comments · Fixed by #5698
Closed

Self name change notification from PK can be seen in groups #5686

anthonybilinski opened this issue May 24, 2019 · 0 comments · Fixed by #5698
Labels
C-bug The issue contains a bug report M-ui Affected Module: User Interface
Milestone
v1.17.0

Comments

@anthonybilinski
Copy link
Member

Brief Description

OS: Ubuntu 19.04
qTox version: v1.16.3+
Commit hash: 22362d2
toxcore: v0.2.9
Qt: 5.12.2
Hardware: Desktop

Reproducible: Rarely

Steps to reproduce

I haven't reproduced this myself, but have heard it reported by others.

  1. Accept group invite.
Observed Behavior
  1. See status message of
Expected Behavior
  1. We always know our own name.
Additional Info

This seems like likely a toxcore oddity of it giving us a peerlist changed with us in the peerlist, but not yet known the "peer"'s name. We could add a short delay on peer list changed of < 1s to allow toxcore's names to usually become consistent - but still show PK after that if no name is set, and we can also just always show our own name for our own PK.

Very likely introduced by b7bd7c6.
@anthonybilinski anthonybilinski added C-bug The issue contains a bug report M-ui Affected Module: User Interface labels May 24, 2019
@anthonybilinski anthonybilinski added this to the v1.17.0 milestone Jun 11, 2019
Kribylet added a commit to Kribylet/qTox that referenced this issue Jun 14, 2019
@Kribylet
fix(group): always retain own name when updating group peer list
c772db3 
Adds special case for updating our own PK in regeneratePeerList
Format according to format-code.sh

Fixes qTox#5686
@Kribylet Kribylet mentioned this issue Jun 14, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-bug The issue contains a bug report M-ui Affected Module: User Interface
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging a pull request may close this issue.

fix(group): always retain own name when updating group peer list Kribylet/qTox
1 participant
@anthonybilinski