Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Reconnect button doesn't reconnect #5710

Closed
yurivict opened this issue Jun 21, 2019 · 1 comment · Fixed by #5721
Closed

Reconnect button doesn't reconnect #5710

yurivict opened this issue Jun 21, 2019 · 1 comment · Fixed by #5721

Comments

@yurivict
Copy link
Contributor

qTox only goes offline, and never comes back online.

Enable UDP - on
Enable LAN discovery - on
No proxy

version 1.16.3.467 (rev.678fc51c) from a package.
FreeBSD 12
@Kribylet
Copy link
Contributor

This is because the Qt signal connections that links the core events to the UI are made during Widget initialization, and reconnecting replaces the core instance without restoring these connections. The new core successfully connects, but the UI never realizes because it does not receive a "connected" signal.

Kribylet added a commit to Kribylet/qTox that referenced this issue Jun 24, 2019
@Kribylet
fix(core): correctly relink ui/core when core is changed
4d74c91 
Widget was only connecting the Core to itself during initialization, but the Core instance could change during a restartCore call. This commit will make Widget link the Core to itself when it changes rather than only on initialization.

Fixes qTox#5710
@Kribylet Kribylet mentioned this issue Jun 24, 2019
Merged
Kribylet added a commit to Kribylet/qTox that referenced this issue Jun 24, 2019
@Kribylet
fix(core): correctly relink ui/core when core is changed
9ce647e 
Widget was only connecting the Core to itself during initialization, but the Core instance could change during a restartCore call. This commit will make Widget link the Core to itself when it changes rather than only on initialization.

Fixes qTox#5710
Kribylet added a commit to Kribylet/qTox that referenced this issue Jun 24, 2019
@Kribylet
fix(core): correctly relink ui/core when core is changed
419ac82 
Widget was only connecting the Core to itself during initialization, but the Core instance could change during a restartCore call. This commit will make Widget link the Core to itself when it changes rather than only on initialization.

Fixes qTox#5710
Kribylet added a commit to Kribylet/qTox that referenced this issue Jun 24, 2019
@Kribylet
fix(core): correctly relink ui/core when core is changed
3cc7242 
Widget was only connecting the Core to itself during initialization, but the Core instance could change during a restartCore call. This commit will make Widget link the Core to itself when it changes rather than only on initialization.

Fixes qTox#5710
Kribylet added a commit to Kribylet/qTox that referenced this issue Jun 26, 2019
@Kribylet
fix(core): correctly relink ui/core when core is changed
17d5d55 
Widget was only connecting the Core to itself during initialization, but the Core instance could change during a restartCore call. This commit will make Widget link the Core to itself when it changes rather than only on initialization.

Fixes qTox#5710
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): correctly relink ui/core when core is changed Kribylet/qTox
2 participants
@yurivict @Kribylet