qTox hangs when login errors or is cancelled (not wrong password)

[anthonybilinski]

Brief Description

OS: Ubuntu 19.04
qTox version: v1.16.3+
Commit hash: 2dde934
toxcore: v0.2.10
Qt: 5.12.2
Hardware: Desktop

…

Reproducible: Rarely

Steps to reproduce

1. Attempt to open locked profile.

or

1. As login screen but before the main screen, ctrl+c - I'm not able to consistently repro this but have seen it a couple times, I think.

Observed Behavior

qTox windows goes away, but qTox does not return - the process hangs indefinitely.

$ qtox -p qTest2
[06:17:34.955 UTC] persistence/settings.cpp:123 : Debug: "Loading settings from /home/abilinski/.config/tox/qtox.ini"
[06:17:35.022 UTC] ipc.cpp:61 : Debug: Our global IPC ID is  9129450030786964297
[06:17:35.023 UTC] main.cpp:274 : Debug: commit:  5b4d9dcd7dc04901e31d99758a712932cf43313d
[06:17:35.025 UTC] persistence/profile.cpp:131 : Warning: Failed to lock profile  "qTest2"
[06:17:35.025 UTC] persistence/settings.cpp:287 : Warning: "Could not load new settings (profile change to nullptr)"


^Z

Expected Behavior

qTox exits.

Additional Info

I think this started happening since 0a30a65

[sudden6]

ping @Kribylet since you were the author of the suspected PR

[anthonybilinski]

I just hit this again running 93c9eef, which includes the linked PR.

Repro steps were simply to open login window, then hit escape.

The login window closes and qTox doesn't exit.