This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
fix(icon): use Qt tray icon in all cases, remove platform specific backends #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonybilinski
force-pushed
the
qt_tray_icon
branch
from
4adc96f
to
ad11885
Compare
anthonybilinski
force-pushed
the
qt_tray_icon
branch
from
ad11885
to
b4bb10b
Compare
anthonybilinski
changed the title
|
Testing completed, results listed at #5881 (comment). No regression found on all tested OSes. |
sudden6
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Please also update INSTALL.md where it lists the dependencies and explains the now removed configuration switches
Reviewed 6 of 6 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
…ckends qTox added specialized tray icon backends over time to work around bugs with the default implementation, since then our GTK+2 backend has stopped working, our appindicator backend was never selected by default by cmake, and statusnotifier was never selected at SystemTrayIcon construction, leaving us only ever using the broken GTK+2 backend, or theoretically the Unity backend, which I didn't see selected on Ubuntu 16.04 Unity. In all other cases we would fall back to the Qt backend. Qt icon has improved over time, and our platform specific icons have become stale, with GTK+2 becoming deprecated and GTK+3 not having a similar feature, QSystemTrayIcon has been tested on a variety of DEs and works as well or better in all cases, as shown in the table at qTox#5881 (comment) Fix qTox#5881 Fix qTox#5859
anthonybilinski
force-pushed
the
qt_tray_icon
branch
from
b4bb10b
to
e85d3f5
Compare
anthonybilinski
commented
Oct 16, 2019
There was a problem hiding this comment.
Please also update INSTALL.md where it lists the dependencies and explains the now removed configuration switches
Done.
Reviewable status: 0 of 1 LGTMs obtained
sudden6
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 LGTMs obtained
anthonybilinski
added a commit
to anthonybilinski/qTox
that referenced
this pull request
Apr 12, 2020
Options were removed in qTox#5888
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qTox added specialized tray icon backends over time to work around bugs with
the default implementation, since then our GTK+2 backend has stopped working,
our appindicator backend was never selected by default by cmake, and
statusnotifier was never selected at SystemTrayIcon construction, leaving us
only ever using the broken GTK+2 backend, or theoretically the Unity backend,
which I didn't see selected on Ubuntu 16.04 Unity. In all other cases we would
fall back to the Qt backend.
Qt icon has improved over time, and our platform specific icons have become
stale, with GTK+2 becoming deprecated and GTK+3 not having a similar feature,
QSystemTrayIcon has been tested on a variety of DEs and works as well or better
in all cases, as shown in the table at
#5881 (comment)
Fix #5881
Fix #5859
This change is