This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
fix(ui): fix auto-accept directory setup display #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonybilinski
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 LGTMs obtained
anthonybilinski
force-pushed
the
fix-autoaccept-ui
branch
from
d645fcc
to
8c5cab9
Compare
|
I've changed the base branch to |
|
Travis seems to be stuck because it was still working on the CI targetting master when I rebased to v1.17-dev branch, so the github check is waiting on a travis job that doesn't exist. Going to try closing and re-opening the PR to see if that will fix it. |
anthonybilinski
added a commit
that referenced
this pull request
Dec 2, 2019
Katherine Mantel (1):
fix(ui): fix auto-accept directory setup display
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a path is passed in to
onAutoAcceptDirChanged, theenabledboolean is mistakenly set to false.Immediately before selecting a path:
Immediately after:
Fixes #5917
This change is