Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hard links for similar images and videos with -L #1201

Merged
merged 1 commit into from Feb 14, 2024

Conversation

blob79
Copy link
Contributor

@blob79 blob79 commented Feb 2, 2024

This ignores matches for files that have the same inode.

This only works on Unix.

This ignores matches for files that have the same inode.

This only works on Unix.
match fs::read_dir(current_folder) {
Ok(t) => Some(t),
Ok(t) => {
// Make directory traversal order stable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will not have big performance impact with bigger folders, because comparing big number of paths are quite time consuming(paths are compared by each component alone)

@qarmin qarmin merged commit b63c631 into qarmin:master Feb 14, 2024
17 checks passed
@qarmin
Copy link
Owner

qarmin commented Feb 14, 2024

Thanks!

@qarmin
Copy link
Owner

qarmin commented Feb 14, 2024

Looks that one test is flaky

failures:

---- common_dir_traversal::tests::test_traversal_group_by_inode stdout ----
thread 'common_dir_traversal::tests::test_traversal_group_by_inode' panicked at czkawka_core/src/common_dir_traversal.rs:769:17:
assertion `left == right` failed
  left: [FileEntry { path: "/tmp/.tmpZCDWnm/a", size: 1, modified_date: 100 }, FileEntry { path: "/tmp/.tmpZCDWnm/c", size: 1, modified_date: 100 }]
 right: [FileEntry { path: "/tmp/.tmpZCDWnm/c", size: 1, modified_date: 100 }, FileEntry { path: "/tmp/.tmpZCDWnm/a", size: 1, modified_date: 100 }]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    common_dir_traversal::tests::test_traversal_group_by_inode

test result: FAILED. 27 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s

error: test failed, to rerun pass `-p czkawka_core --lib`
Error: Process completed with exit code 101.

@blob79
Copy link
Contributor Author

blob79 commented Feb 14, 2024

Should be fix here #1209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants