High memory usage in localMonthNamesXhosa

[nathj07]

Description

Whilst reading XLSX files I've noticed large amounts of memory being consumed.

These pprof SVGs show where the issue appears to be - localMonthsNameXhosa. I have seen it for other local months names too, but Xhosa is the biggest. Sadly I do not have an XLSX file available that will reproduce this issue for you, but hopefully knowing where the high memory usage is ocurring will aid in finding a resolution.

Output of go version:

go version go1.19.4 darwin/amd64

Excelize version or commit ID:

github.com/xuri/excelize/v2 v2.7.0

Environment details (OS, Microsoft Excel™ version, physical, etc.):
This occurs when running in a Docker Container based on RockyLinux: 8.6 with 8G memory and 4vCPU on a K8s cluster

[dankinder]

Notably, localMonthsNameXhosa is one of the ones that creates new strings via concatenation, where e.g. English doesn't

excelize/numfmt.go

Line 385 in b39626f

func localMonthsNameEnglish(t time.Time, abbr int) string {

It would be quite straightforward to refactor these functions to pre-generate the abbreviation variations instead of allocating new strings. It would be good to know if the authors would welcome a PR that does that.

[xuri]

Thanks for your issue. Contributions are welcome. I'll certainly accept this patch if anybody did that.

[nathj07]

Let me know if this is not the way you want to go, can totally close this and go a different way. Or I can add to this if there are other funcs that need this treatment.