Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear data validation #1255

Merged
merged 5 commits into from
Jun 15, 2022
Merged

clear data validation #1255

merged 5 commits into from
Jun 15, 2022

Conversation

z-hua
Copy link
Contributor

@z-hua z-hua commented Jun 15, 2022

PR Details

Description

add a method to clear data validation

Related Issue

#1254

Motivation and Context

provide a method to clear data validation give by worksheet name when need

How Has This Been Tested

execute TestClearDataValidation

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I suggest making the second parameter as optional on the existing function DeleteDataValidation to delete all data validation on a worksheet instead of introducing a new export function.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2022
@z-hua z-hua requested a review from xuri June 15, 2022 08:43
@z-hua
Copy link
Contributor Author

z-hua commented Jun 15, 2022

I'm not sure if need to traverse DeleteDataValidation's second parameter when make it optional, now I just consider the first element, that is sqref[0].

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #1255 (bede170) into master (7f570c7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          31       31           
  Lines       22908    22912    +4     
=======================================
+ Hits        22550    22554    +4     
  Misses        239      239           
  Partials      119      119           
Flag Coverage Δ
unittests 98.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datavalidation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f570c7...bede170. Read the comment docs.

datavalidation.go Outdated Show resolved Hide resolved
datavalidation_test.go Outdated Show resolved Hide resolved
@xuri xuri merged commit 5beeeef into qax-os:master Jun 15, 2022
@xuri
Copy link
Member

xuri commented Jun 15, 2022

LGTM, thanks for your contribution.

@z-hua z-hua deleted the clear-datavalidation branch June 15, 2022 09:44
@xuri xuri added this to Feature in v2.6.1 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
v2.6.1
Feature
Development

Successfully merging this pull request may close these issues.

None yet

3 participants