Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This closes #1732, saving workbook with sorted internal part path #1735

Merged
merged 1 commit into from Nov 30, 2023

Conversation

user65536
Copy link
Contributor

PR Details

Description

This closes #1732, saving workbook with sorted internal part path

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2023
@xuri xuri added this to Improve the Compatibility in v2.8.1 Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (866e7fd) 99.05% compared to head (972917f) 99.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
+ Coverage   99.05%   99.06%   +0.01%     
==========================================
  Files          32       32              
  Lines       28469    28474       +5     
==========================================
+ Hits        28199    28207       +8     
+ Misses        179      177       -2     
+ Partials       91       90       -1     
Flag Coverage Δ
unittests 99.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit a16182e into qax-os:master Nov 30, 2023
39 checks passed
xuri added a commit to barlevd/excelize that referenced this pull request Apr 30, 2024
Saving workbook with reverse sorted internal part path to keep same hash of identical files
xuri pushed a commit that referenced this pull request Apr 30, 2024
Saving workbook with reverse sorted internal part path to keep same hash of identical files and fix incorrect MIME type
barlevd added a commit to barlevd/excelize that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
v2.8.1
Improve the Compatibility
Development

Successfully merging this pull request may close these issues.

Hash of identical files
3 participants