Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new formula func CLEAN and TRIM, change import path to v2 #747

Merged
merged 1 commit into from Dec 14, 2020

Conversation

peng
Copy link
Contributor

@peng peng commented Dec 13, 2020

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2020
@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #747 (ad10f03) into master (61057c5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          31       31           
  Lines        8583     8596   +13     
=======================================
+ Hits         8301     8314   +13     
  Misses        160      160           
  Partials      122      122           
Impacted Files Coverage Δ
cell.go 97.88% <ø> (ø)
chart.go 100.00% <ø> (ø)
picture.go 98.99% <ø> (ø)
pivotTable.go 98.77% <ø> (ø)
calc.go 94.89% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61057c5...ad10f03. Read the comment docs.

@xuri xuri merged commit ad79505 into qax-os:master Dec 14, 2020
@xuri
Copy link
Member

xuri commented Dec 14, 2020

LGTM, thank you @peng.

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants