Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #7

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Refactor #7

merged 2 commits into from
Nov 16, 2021

Conversation

qbantek
Copy link
Owner

@qbantek qbantek commented Nov 16, 2021

  • Remove redundant test
  • Extract port validation into function
  • Disallow empty port values, the default port is 80 not empty.

- Extract port validation into function
- Disallow empty port values, default port is 80 not empty.
@qbantek qbantek added the enhancement New feature or request label Nov 16, 2021
@qbantek qbantek self-assigned this Nov 16, 2021
@qbantek qbantek merged commit 1e80c64 into master Nov 16, 2021
@qbantek qbantek deleted the chore/refactor branch November 16, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant