A number of improvements to boolean values & a unit test fwk #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it broke in rebase. Will fix after lunch |
Some nodes are always boolean-typed, but some are only sometimes boolean-typed but can still contribute reasonable information.
As a follow-up, we will want to devise a merging algorithm which combines constraints and then picks a final input, perhaps adding a `ConstrainEq` for the other input
Also introduce a comprehensive suite of simple boolean reductions and canonicalizations
|
Fixed |
dmlloyd
changed the title
dgrove-oss
reviewed
Nov 19, 2021
dgrove-oss
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compones-complement node, use it as canonical form for boolean inversionInstanceOfvalue-if-true (allows optimizations to simplify it)