Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-subdirectories flag #169

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

KochTobi
Copy link
Member

The default behaviour for the download command is to create the same directory structure on the client as on the server, prefixed with the specified output directory.

This flag ignores the directory structure and downloads all files into the output directory directly grouped by dataset sample.
Caution: This might lead to files with the same names overwriting each other.

@KochTobi KochTobi requested a review from a team as a code owner July 27, 2023 12:08
@KochTobi KochTobi marked this pull request as draft July 27, 2023 12:09
@KochTobi
Copy link
Member Author

Waiting for feedback from feature requester.

@KochTobi KochTobi changed the title Add --ignore-directories flag Add --ignore-subdirectories flag Aug 7, 2023
@KochTobi KochTobi marked this pull request as ready for review August 7, 2023 11:55
Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @KochTobi ,
Nice work, i only found a minor inconsistency in the readme, but this PR is g2g.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@KochTobi KochTobi merged commit 3fa1cd9 into development Aug 7, 2023
3 checks passed
@KochTobi KochTobi deleted the feature/add-ignore-directory-option branch August 7, 2023 13:19
KochTobi added a commit that referenced this pull request Aug 7, 2023
Add `--ignore-subdirectories` flag (#169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants