Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ideas #149

Open
Poopooracoocoo opened this issue Nov 28, 2020 · 2 comments
Open

Some ideas #149

Poopooracoocoo opened this issue Nov 28, 2020 · 2 comments

Comments

@Poopooracoocoo
Copy link
Contributor

Poopooracoocoo commented Nov 28, 2020

What are your thoughts on the following?

  • changing the links in the header to be their destinations instead of wiki.qbittorrent.org, for example.
  • adding a donate link to the header or perhaps a donate button
  • removing the "version ribbon"
    image
a problem I had

When I tried making the header image fit the width for smaller widths, the height would shrink and the ribbon took up the same amount of space while the menu moved up. This meant that the first few menu items couldn't be accessed! I solved this by making the height stay the same. It could've been solved by changing the ribbon so that clicks go through as there's enough space. https://github.com/simonwhitaker/github-fork-ribbon-css does it better than https://github.com/codepo8/css-fork-on-github-ribbon IMO, but I'm sure there's a way to fix up the current one. Edit: Fixed it with pointer-events!

Screenshot of this problem

image

  • removing the "latest version this way" download image
    image
  • adding a "Download version x.x.x" button
  • modifying Chris's banner to not have the "Free and reliable P2P Bittorrent client" text and to replace that with actual text
@Chocobo1
Copy link
Member

Chocobo1 commented Dec 5, 2020

I can only answer a few of them, for others I don't have a opinion yet.

changing the links in the header to be their destinations instead of wiki.qbittorrent.org, for example.

This was suggested in the past and we choose to keep the current way.

adding a donate link to the header or perhaps a donate button

I don't mind, but I also think the header is already a little full for another entry.

removing the "version ribbon"

I don't think we will do this.

removing the "latest version this way" download image

I don't mind, we can try and see how it looks.

modifying Chris's banner to not have the "Free and reliable P2P Bittorrent client" text and to replace that with actual text

I would like to avoid lossy operations on the image file unless you are able to do it in a pixel-perfect way.
IMO a even better idea is to redraw it in svg format, but I guess this is too much work.

@Poopooracoocoo
Copy link
Contributor Author

removing the "latest version this way" download image

I don't mind, we can try and see how it looks.

It could be replaced by a different image/SVG or even a CSS button!

modifying Chris's banner to not have the "Free and reliable P2P Bittorrent client" text and to replace that with actual text

I would like to avoid lossy operations on the image file unless you are able to do it in a pixel-perfect way.
IMO a even better idea is to redraw it in svg format, but I guess this is too much work.

yeah, redrawing in SVG is too hard. I didn't know that editing it out would lose quality. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants