Default category preference not saved for future torrents

[ghost]

Please provide the following information

qBittorrent version and Operating System

V4.2.2 macOS 10.14.6

If on linux, libtorrent-rasterbar and Qt version

(type here)

What is the problem

When setting the default category to "Movie" in the torrent dialog window and selecting "save as default" the option is not saved for future torrents (after choosing not to display the torrent dialog in future torrents in preferences). Choosing to show the torrent dialog again shows that the default is still selected as "Movie" but new torrents don't have that category.

What is the expected behavior

After setting "Movie" as the default category and choosing not to view torrent dialog when adding a torrent that all torrents are tagged with "Movie" for their category

Steps to reproduce

1. In Downloads Prefs check "display torrent content and some options"
2. add a torrent
3. when the torrent dialog appears select Category "Movies"
4. check the box below for "set as default category"
5. Click "OK"
6. Open Downloads Preferences and deselect "display torrent content and some options"
7. Click "Apply"

Extra info(if any)

Thank you

[glassez]

The option that you use in "Add Torrent" dialog affects "Add Torrent" dialog itself only. qBittorrent has no global "Default category" option.

[ghost]

I understand now. It wasn't clear. Other settings appear to be global in that same dialog box.

I suppose I should create a "feature" request?

It seems counterproductive in conjunction with the option to avoid the dialog window which is arguably there to streamline the download experience. I use a script that looks for a "category" when post processing torrents. A category helps this script decide if it's a movie or tvshow.

[FranciscoPombal]

I agree with @jprokos, the option should probably be renamed to "remember category selection for future added torrents" or equivalent.

The way it is now, it makes it seem like future added torrents will be assigned that category by default.

@jprokos For now, don't create a new "feature request" issue, let's continue the discussion and hear more opinions first. @glassez @Chocobo1

[glassez]

the option should probably be renamed to "remember category selection for future added torrents" or equivalent.

"Remember category selection" is what it really does so it should be renamed accordingly.

[FranciscoPombal]

@glassez

"Remember category selection" is what it really does.

Yes, but that's not obvious from its current description/name.

[ghost]

@FranciscoPombal Renaming would avoid confusion. @glassez was suggesting that very thing

...it should be renamed accordingly.

A global default — this feature would be helpful. Where would that global preference live?? I don't know what would be consistent with the current user interface.

[FranciscoPombal]

@glassez

"Remember category selection" is what it really does so it should be renamed accordingly

I was recently thinking about this. I don't think renaming the checkbox to "Remember category selection" will be of any help - the users will have the expectation that the remembered category will actually be applied in the future. Why not remove the checkbox altogether, and always remember the last used category in the dialog? This will prevent the expectation that the category is set as default even when not using the dialog. Then, later, a proper "default category" option that controls the default assigned category (regardless of whether the "add torrent dialog" is skipped) can be implemented in the settings.

One question - if we do decide to remove it, do I have to delete the corresponding entry from the TS files?