Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text box is not focused in the Rename dialog (QTBUG-120049) #20084

Open
jinliu opened this issue Dec 2, 2023 · 7 comments
Open

The text box is not focused in the Rename dialog (QTBUG-120049) #20084

jinliu opened this issue Dec 2, 2023 · 7 comments
Labels
GUI GUI-related issues/changes Qt bugs Bug resides in Qt library

Comments

@jinliu
Copy link

jinliu commented Dec 2, 2023

qBittorrent & operating system versions

qBittorrent: 4.6.2 x64
Operating system: Linux
Qt: 6.6.1
Libtorrent: 2.0.9.0
Boost: 1.83.0
OpenSSL: 3.1.4
zlib: 1.3

What is the problem?

When pressing F2 to rename a torrent, in previous versions, the textbox is focused in the dialog. But in the current version, the OK button is focused instead, requiring a mouse click to edit the text.

Steps to reproduce

  1. Select a torrent.
  2. Press F2
  3. Focus is on the OK button.

Additional context

No response

Log(s) & preferences file(s)

No response

@glassez glassez added the GUI GUI-related issues/changes label Dec 2, 2023
@glassez
Copy link
Member

glassez commented Dec 2, 2023

Works correctly on Windows.
@qbittorrent/bug-handlers, could someone test it on Linux?

@jinliu
Copy link
Author

jinliu commented Dec 2, 2023

Some more info:

  1. I'm running Archlinux, KDE Plasma 6 beta, Wayland.
  2. The problem happens in both X11 and Wayland (qbittorrent -platform xcb/wayland)
  3. Tags-Add has the same problem, so probably it's in the AutoExpandableDialog they both use.
  4. Seems it doesn't set focus explicitly, so perhaps it's QT who changed which widget gets focused by default:
    d.m_ui->textEdit->selectAll();

@thalieht
Copy link
Contributor

thalieht commented Dec 2, 2023

Luckily i tested it before i updated my system. Qt 6.6.0: Can't reproduce, Qt 6.6.1: Can reproduce.

@luzpaz
Copy link
Contributor

luzpaz commented Dec 3, 2023

Can't reproduce on

Manjaro 23.0.2
v5.0.0alpha1 (64-bit)
Qt: 6.5.2
Libtorrent: 2.0.9.0
Boost: 1.76.0
OpenSSL: 3.0.2
zlib: 1.3

@ManuLinares
Copy link

Can reproduce

Archlinux:

pkg ver
qbittorrent 4.6.2-2
qt6-base 6.6.1-1
xorg-server 21.1.9-1

It's annoying as ****, I always press F2, CTRL-C to copy the name and paste it in the search tab to search for the next episode in a series.

This small change in behaviour is strange as one would expect when renaming a torrent, the focus would be on the text...

@glassez
Copy link
Member

glassez commented Dec 8, 2023

Qt 6.6.0: Can't reproduce, Qt 6.6.1: Can reproduce.

Could you test #20103?
Unfortunately I'm still under v6.6.0.

@glassez glassez added the Qt bugs Bug resides in Qt library label Dec 12, 2023
@glassez
Copy link
Member

glassez commented Dec 12, 2023

QTBUG-120049

@xavier2k6 xavier2k6 changed the title The text box is not focused in the Rename dialog The text box is not focused in the Rename dialog (QTBUG-120049) May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes Qt bugs Bug resides in Qt library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants