Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change temporary copy behaviour #7113

Open
donselmo opened this issue Jul 17, 2017 · 5 comments
Open

Change temporary copy behaviour #7113

donselmo opened this issue Jul 17, 2017 · 5 comments

Comments

@donselmo
Copy link

donselmo commented Jul 17, 2017

qBittorrent version and Operating System:

3.3.13 on Windows 10 x64 Pro

What is the problem:

I have fiber internet (1gigabit), so I using a ramdisk for temporary folder avoid HDD stress and I/O limit. Because of the speed, I often got bad pieces so I set on the verify after download option. The problem is, after the download is complete, files copied the destination folder, then verified. Verify get some missing pieces - usually couple of MiB - so copy back the whole torrent, redownload missing pieces, then copy it's destination folder and verify again. This could be insane if you have only 1 HDD and your torrent is some BD with ~50 GiB and you got an useless PC for 30 min because of copying and recopying. I have 3 HDD and using a ramdisk, but my PC still slowing down. This was my first problem.
The second is the half downloaded paused torrents. Because of the ramdisk, I often got the problem to remove some slow torrents and use the fast ones. If I uncheck temporary folders, all files copied it's destination folder. Thats good. But if I recheck, all - even paused - torrents begin to copy itself to the temporary folder. Thats made useless a ramdisk.

What is the expected behavior:

  1. Verify before copy, only copy destination folders, when verify got 100% torrent state.

  2. Paused torrents do not use the temporary folder and/or the option to set every torrent to exclude the temporary folder and use only it's destination folder.

@zeule
Copy link
Contributor

zeule commented Jul 17, 2017

To your first concern I would like to note that you show a quite specific use-case. I believe most of the users want verification to be done with the final set of files (in the final destination directory) because those are the files they want to keep.

@donselmo
Copy link
Author

I agree, most users are probably never use both option. I'm not a programmer, but I think it's just a small work to change the sequence and do verify before copy. And in rare case's it will be good for SSD's lifetime by avoiding unnecessary copy.
And sorry, but I dont get your second tought. If you use the temp folder, qB use only that, and move the files to the destination folder only when the download is 100% complete. Assuming that copy is always 100% safe, there is no difference verify before or after that move.
Or I just misleading you, because qB is using my language and I just translate "verify", and the proper english name of the option is: Recheck torrents on completion so it's obviously happening after all the files are downloaded 100%

@zeule
Copy link
Contributor

zeule commented Jul 17, 2017

… and do verify before copy.

My point is that most of the users want verify to be done after copying.

Assuming that copy is always 100% safe…

Well, every piece is checked when received. so downloading in this scheme is 100% safe too.

@glassez
Copy link
Member

glassez commented Jul 24, 2017

How about #7137?

@glassez
Copy link
Member

glassez commented Jul 25, 2017

Please see also #7164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants