Display problems in v3.0.10!

[Oneofus08]

Torrents have a problem displaying when the Windows 8 is selected to display a larger size for monitor or a large HD TV (125% -150%)
The setting is found in Windows: right clic - personalize - display - change the size of all items-larger -150%
Previous version 3.0.9 had no problems.
OS-Windows 8 x64

http://imageshack.us/photo/my-images/89/zuxl.jpg/

[sledgehammer999]

Can you post a pic that shows how it should look with 100%?
I don't understand what is the problem... :S

[Gelmir]

I suppose he means that increasing fonts size yields those results.
My guess: this behavior is caused by d095d7f

[sledgehammer999]

Damn. On WindowsXP increasing the dpi to 150% shows the same problem. The row's height doesn't get increased correctly. I am currently debuging the problem.

[sledgehammer999]

The problem is with QFontMetrics::height() it returns the same size regardless of the dpi.

[Gelmir]

Can we just partially revert that commit, by removing changes made to TorrentModel::data?

P.S. Speaking of height. It is possible to have a newline in torrent name (rename by copying text, containing a newline)

[sledgehammer999]

Can we just partially revert that commit, by removing changes made to TorrentModel::data?

I was investingating if the is another way to get the font height. Unfortunately I found none. So our best "option" is to revert. Actually this fixed another cosmetic bug. When a user scrolls horizontally and the "name" column disappears entirely from the view, the row's height get smaller(at least on Windows XP) and look thinner. The row get's the height of the font, since no image is drawn.

P.S. Speaking of height. It is possible to have a newline in torrent name (rename by copying text, containing a newline)

This needs fixing.

[Oneofus08]

sledgehammer999 commented "Can you post a pic that shows how it should look with 100%?"

Still necessary? At 100% the display is ok.
I hope you fix this bug.

[sledgehammer999]

Still necessary?

No.

[ghost]

Its not just the wrong size it also appears to have alignment problem. Some columns the text seems to be baseline, others top and still others sub.

[sledgehammer999]

When changing the DPI Windows tells you that for the changes to take effect system-wide you need to restart the PC. Did you do that? If not, please do and try again.

On my Windows XP box after I rebooted the text was shown correctly.

[ghost]

I have the same issue. After reboot the alignment problem remains.

[sledgehammer999]

@AltPlusF4 but is the row height big enough after reboot?

[ghost]

No, it's the same.

Win7 x64 here.

BTW, let me just thank you sledgehammer999 for all the hard work, it's greatly appreciated.

[sledgehammer999]

BTW, let me just thank you sledgehammer999 for all the hard work, it's greatly appreciated.

You're welcome.

@Others Please respond if after reboot it is ok.

As it seems I'll have to revert the change, and do a bug report to Qt.

[ghost]

Screenshot: http://postimg.org/image/wus733gcz/
BTW been using qBiT for a couple-three years now on both windows 7 and Linux with much success.
My Previous torrent client was Free Download Manager.

Thanks to all of you for a great torrent client.

[ghost]

@sledgehammer999
I've rebooted several times just because I was moving locations.
No change in the layout. This is windows 7 64bit.
I haven't updated my Linux box yet so I don't know what it's doing.

[Oneofus08]

You have the same problem with v. 3.1 alfa.
Thanks anyway!

[Gelmir]

@sledgehammer999, still no better solution than partial revert available?

[sledgehammer999]

I am still looking at it. I have marked with the v3.0.11 milestone so I won't forget. Worst case scenario I'll do the partial revert.

Currently looking at the delegate code to see how it manages to paint it with the correct DPI even though FontMetrics returns wrong values.

[Gelmir]

@sledgehammer999, I cannot test this today, but does fontMetrics from QPainter yield a different result?

[sledgehammer999]

I cannot test this today, but does fontMetrics from QPainter yield a different result?

Unfortunately no.