Add 1337x search plugin #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2018
ngosang
force-pushed
the
feature/1337x
branch
from
8c3e579
to
28438d8
Compare
|
Does this change only affects the newer releases or old ones too? AFAIK, old plugin engine versions don't support magnet links. |
|
@v1k45 affects all qbittorrent versions, users with old versions too. It should work in all versions. |
|
@Chocobo1 could you do the pep8 fixes for me? |
OK, but it will be later, short on free time right now... |
ngosang
force-pushed
the
feature/1337x
branch
from
28438d8
to
b980f61
Compare
ngosang
force-pushed
the
feature/1337x
branch
from
b980f61
to
bfcd9f7
Compare
|
I did, all PRs are ready to review. |
Chocobo1
reviewed
Sep 17, 2018
| @@ -1,5 +1,6 @@ | |||
| btdb: 1.04 | |||
| eztv: 1.01 | |||
| leetx: 2.00 | |||
There was a problem hiding this comment.
why the name is different? can't you use 1337x?
There was a problem hiding this comment.
The file name must be the same as the class name and the class name can't start with numbers.
There was a problem hiding this comment.
ok, no more question from me, proceed as you see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @v1k45 source code https://github.com/v1k45/1337x-qBittorrent-search-plugin
Changes: