Remove pass-by-value from RulesApplicator

References were assigned to a temporary object This amends 936eee7 Change-Id: I1d2b6c00cd75ddb4759017490fd63ab123be4825 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
qbs · Nov 25, 2019 · 491b293 · 491b293
1 parent 6f8feb9
commit 491b293
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/lib/corelib/buildgraph/rulesapplicator.cpp b/src/lib/corelib/buildgraph/rulesapplicator.cpp
@@ -79,12 +79,13 @@ namespace Internal {
 
 RulesApplicator::RulesApplicator(
         ResolvedProductPtr product,
-        std::unordered_map<QString, const ResolvedProduct *> productsByName,
-        std::unordered_map<QString, const ResolvedProject *> projectsByName,
+        const std::unordered_map<QString, const ResolvedProduct *> &productsByName,
+        const std::unordered_map<QString, const ResolvedProject *> &projectsByName,
         Logger logger)
     : m_product(std::move(product))
-    , m_productsByName(std::move(productsByName))
-    , m_projectsByName(std::move(projectsByName))
+    // m_productsByName and m_projectsByName are references, cannot move-construct
+    , m_productsByName(productsByName)
+    , m_projectsByName(projectsByName)
     , m_mocScanner(nullptr)
     , m_logger(std::move(logger))
 {

diff --git a/src/lib/corelib/buildgraph/rulesapplicator.h b/src/lib/corelib/buildgraph/rulesapplicator.h
@@ -63,8 +63,8 @@ class RulesApplicator
 {
 public:
     RulesApplicator(ResolvedProductPtr product,
-                    std::unordered_map<QString, const ResolvedProduct *> productsByName,
-                    std::unordered_map<QString, const ResolvedProject *> projectsByName,
+                    const std::unordered_map<QString, const ResolvedProduct *> &productsByName,
+                    const std::unordered_map<QString, const ResolvedProject *> &projectsByName,
                     Logger logger);
     ~RulesApplicator();