Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3999 and beyond #30

Closed
pieterdd opened this issue Apr 17, 2022 · 2 comments
Closed

3999 and beyond #30

pieterdd opened this issue Apr 17, 2022 · 2 comments

Comments

@pieterdd
Copy link

Some rulesets allow M sequences of more than 3 characters so you can express numbers above 4000. I'm aware that this is not universal, and noticed that romans throws an exception for 'MMMM'. Is this a conscious design choice?

@qbunt
Copy link
Owner

qbunt commented May 7, 2022

Hey @pieterdd, yes, it's a conscious design decision. It's an imperfect numbering system for sure, the limit is in place because it's the closest I can find to a universal max value. Believe it or not someone posted another issue that they could go over 4,000 so now I run unit tests against that max.

If you have a use-case for it, I'm sure there's a way I could support exceeding that limit, also open to PRs to support it too. Thanks for filing the issue!

@pieterdd
Copy link
Author

pieterdd commented May 7, 2022

This answers my question, thanks qbunt!

@pieterdd pieterdd closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants