ath9k_htc driver is not smart enough

[nicocesar]

I got a:

[ 646.367797] ath9k_htc 1-5:1.0: ath9k_htc: FW Version: 1.4
[ 646.367807] ath9k_htc 1-5:1.0: ath9k_htc: Please upgrade to FW version 1.3

on a 3.8.5 kernel installed from:

http://linux-libre.fsfla.org/pub/linux-libre/freesh/pool/main/l/linux-libre32-3.8/linux-libre32-3.8_3.8.5_i386.deb

on a trisquel 6.0

[nicocesar]

I edditted
target_firmware/wlan/include/magpie/wlan_cfg.h
target_firmware/wlan/include/k2/wlan_cfg.h

changing ATH_VERSION_MINOR to 3

and recompile and worked just fine. so it's a check in the driver.

[erikarn]

Yup, it's a check in the driver.

ath9k_htc will need updating to accept both 1.3 and 1.4 firmware.

Thanks,

Adrian

On 2 April 2013 14:44, nicocesar notifications@github.com wrote:

I edditted
target_firmware/wlan/include/magpie/wlan_cfg.h
target_firmware/wlan/include/k2/wlan_cfg.h

changing ATH_VERSION_MINOR to 3

and recompile and worked just fine. so it's a check in the driver.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-15804692
.

[nicocesar]

For the reccord (I'm trying to file in a bug to the linux kernel hackers. wish me luck)

the check should be changed on:

http://lxr.free-electrons.com/source/drivers/net/wireless/ath/ath9k/htc_drv_init.c?v=3.4;a=arm#L773

Instead of a " != " should be something more intelligent

Since we have version 1.4 now:

4c9d9e8

[erikarn]

Right. It should just check for 1.3 and 1.4.

adrian

On 3 April 2013 13:22, nicocesar notifications@github.com wrote:

For the reccord (I'm trying to file in a bug to the linux kernel hackers.
wish me luck)

the check should be changed on:

http://lxr.free-electrons.com/source/drivers/net/wireless/ath/ath9k/htc_drv_init.c?v=3.4;a=arm#L773

Instead of a " != " should be something more intelligent

Since we have version 1.4 now:

4c9d9e84c9d9e8

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-15861870
.

[KrasnikovEugene]

Suggestion is to check only major version because:
Major version must be changed only e.g. when FW api changed.
Minor version must be changed on some small changes/improvements/bugfixes.
Will suggest to ath9k_htc guys.

[erikarn]

On 4 April 2013 07:19, KrasnikovEugene notifications@github.com wrote:

Suggestion is to check only major version because:
Major version must be changed only e.g. when FW api changed.
Minor version must be changed on some small changes/improvements/bugfixes.

Yup. I just wrote this down in a wiki page.

Adrian

[KrasnikovEugene]

is this fixed in latest driver? Do you have a patch to share or anything?:)

[mathieu-clement]

This has been corrected in source code:
http://lxr.free-electrons.com/source/drivers/net/wireless/ath/ath9k/htc_drv_init.c?a=arm#L799

However, I must say on my Raspberry I didn't get that update yet. So in the meantime nicocesar's patch does the trick.