Issue #9 Archiving all cards in a list #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcam
reviewed
Apr 27, 2018
There was a problem hiding this comment.
@onurbozkurt Thanks so much for the PR. It looks great. I left a few comments and could you also resolve the conflict from the master branch?
| def prompt_for_approvement! | ||
| Tr3llo::Presenter::ConfirmationPresenter | ||
| .new(interface) | ||
| .prompt_for_confirmation('Are you sure you wan\'t to archive all cards?') |
lib/3llo/presenter/confirmation.rb
Outdated
| private | ||
|
|
||
| attr_reader :interface | ||
|
|
There was a problem hiding this comment.
Could you remove this extra newline?
onurbozkurt
force-pushed
the
archiving-all-cards-in-a-list
branch
from
6b9c4f3
to
2c34e24
Compare
|
I've updated both files. |
|
@onurbozkurt ❤️Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.
I've added lib/3llo/presenter/confirmation.rb for a confirmation prompt which can be used when needed. But I'm not sure about the location of the file.