Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab styling #35

Closed
Stephen-Gates opened this issue Aug 12, 2017 · 3 comments
Closed

Tab styling #35

Stephen-Gates opened this issue Aug 12, 2017 · 3 comments
Labels
fn:Interface Help wanted We'd love your help with this issue or pull request
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Aug 12, 2017

Current Behaviour

The Tab close button is a bit loud.
screenshot 2017-08-12 18 35 19

Also Tab baseline should match panel header baseline

tab-alignment

Expected Behaviour

  • change colour of X to grey
  • remove background colour (red)
  • show X on hover over Tab
  • hide X when no hover over Tab
  • shade inactive Tabs a darker colour than the active Tab (e.g. the current hover over colour)
  • baselines align e.g.

screenshot 2017-08-17 20 13 02

@ghost
Copy link

ghost commented Aug 17, 2017

OK will line this up and #38 for next release.

@Stephen-Gates Stephen-Gates modified the milestones: v0.2.0, v0.1.0 Aug 17, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.2.0, v0.3.0 Sep 1, 2017
@Stephen-Gates
Copy link
Contributor Author

Essentially fixed. Very minor styling issue remains
screenshot 2017-09-08 06 56 10

@Stephen-Gates
Copy link
Contributor Author

Remaining styling issue - remove background from close buttons

Current behaviour

Inactive tab, No hover:
screenshot 2017-09-08 06 56 20

on hover over close on inactive tab:
screenshot 2017-09-08 06 56 29

Expected behaviour

  • close button not shown on active tab
  • on hover over active tab, close button shown
  • close button not shown on inactive tabs
  • on hover over inactive tab:
    • close button shown
    • tab shaded
  • screenshot 2017-09-08 06 56 29

@Stephen-Gates Stephen-Gates unassigned ghost Sep 8, 2017
@Stephen-Gates Stephen-Gates added the Help wanted We'd love your help with this issue or pull request label Sep 8, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.3.0, Backlog Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fn:Interface Help wanted We'd love your help with this issue or pull request
Projects
None yet
Development

No branches or pull requests

1 participant