fix(noip): useproviderip and no ip returned case

qdm12 · May 6, 2024 · 542e895 · 542e895
1 parent 093e815
commit 542e895
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/internal/provider/providers/noip/provider.go b/internal/provider/providers/noip/provider.go
@@ -177,7 +177,11 @@ func (p *Provider) Update(ctx context.Context, client *http.Client, ip netip.Add
 		ips = ipextract.IPv6(s)
 	}
 
-	if !useProviderIP && len(ips) == 0 {
+	if len(ips) == 0 {
+		if useProviderIP {
+			// No returned ip address from noip server
+			return ip, nil
+		}
 		return netip.Addr{}, fmt.Errorf("%w", errors.ErrReceivedNoIP)
 	}