-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linode support #144
Linode support #144
Conversation
47c7190
to
0a0cfdf
Compare
internal/settings/linode.go
Outdated
} | ||
r.Header.Set("Content-Type", "application/json") | ||
r.Header.Set("Authorization", "Bearer "+l.token) | ||
r.Header.Set("oauth", "domains:read_only") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be mistaken, but given we're using a personal access token, I don't think we need to define oauth headers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the review 👍
That's what they have on their documentation.
You can probably define tokens with different kind of permissions.
It might not work if you don't precise which permission you want, but I can't test it for sure, I don't have an account 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! When creating the token, I had to assign permissions to it, but better to go with what the documentation says :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting which permissions? Are these the same as in the code? So I can add these to the Linode documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a87609a
to
a9928d0
Compare
Fixes #143