Golibs logger update #170
Merged
Golibs logger update #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
golibs-logger-update
branch
from
3d8cb70
to
6a3cd63
Compare
fredericrous
reviewed
Mar 2, 2021
There was a problem hiding this comment.
I come after the battle but, approved, nice work. Maybe in the readme change the description Show caller per log line by something more user friendly. What is a caller?
Regarding LOG_ENCODING. I think getting the logs as json was indeed not used by anyone, we'll see if someone opens an issue xD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran it and seems to work nicely (after a few fixes!)
Then feel free to do a PR to add debug logs where you would want some 馃槈 You can also directly branch off this repository if you want too, if that's easier for you.